Approve

How it is used

On GitHub a reviewer can choose 'Approve', 'Comment' or 'Request changes'. People say 'approved with minor comments' or 'it needs two approvals'. Note the difference: you 'approve of' an idea you like, but you simply 'approve' a request.

Example sentences

1. I approved your PR, but please fix the typo in the README before merging.

2. This change needs approval from two reviewers because it touches billing.

Common collocations

• approve a pull request
• get approval
• approved with comments
• needs two approvals

Related terms

• reviewerA teammate who reads and checks someone else's code changes, usually in a pull request, before they are allowed to be merged.
• code reviewThe practice of teammates reading and commenting on each other's code changes before they are merged, to catch problems and share knowledge.
• LGTMShort for 'looks good to me': a quick written comment a reviewer leaves to say that a code change is fine and can be merged.
• pull requestA request to merge your code changes from one branch into another, so that teammates can review and discuss them first.

More terms: Code Review and Code Quality

• refactor
• technical debt
• nitpick
• address feedback
• linter
• hard-coded
• code smell
• readable
• best practice
• clean code
• maintainable
• naming convention